Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish the JDWP spec #10

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Finish the JDWP spec #10

wants to merge 9 commits into from

Conversation

necauqua
Copy link
Owner

This will definitely trigger codecov as there are no tests ¯\_(ツ)_/¯

Well, will see how bad it is and proceed to cover everything anyway.

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #10 (77ab1b5) into main (0c9393a) will increase coverage by 1.92%.
The diff coverage is 39.35%.

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   43.71%   45.63%   +1.92%     
==========================================
  Files          19       20       +1     
  Lines        1082     2281    +1199     
  Branches     1082     2281    +1199     
==========================================
+ Hits          473     1041     +568     
- Misses        525     1097     +572     
- Partials       84      143      +59     
Files Changed Coverage Δ
src/highlevel/event.rs 0.00% <0.00%> (ø)
src/highlevel/method.rs 0.00% <0.00%> (ø)
src/spec/commands.rs 80.45% <ø> (ø)
src/spec/constants.rs 3.49% <3.49%> (ø)
src/highlevel/field.rs 6.59% <6.59%> (ø)
src/jvm.rs 30.76% <7.69%> (+0.02%) ⬆️
src/spec/types.rs 22.22% <22.22%> (ø)
src/highlevel/mod.rs 60.00% <60.00%> (ø)
src/spec/protocol.rs 62.50% <62.50%> (ø)
src/codec.rs 61.11% <65.00%> (-8.56%) ⬇️
... and 9 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@necauqua necauqua force-pushed the dev branch 2 times, most recently from 37ba128 to ed97d2d Compare July 26, 2023 00:54
@necauqua necauqua force-pushed the dev branch 4 times, most recently from 110d66d to ac74970 Compare July 26, 2023 02:53
@necauqua
Copy link
Owner Author

idk just merge it I guess

bors r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant