Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make error message in mmseqs check prettier #114

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

ivan-aksamentov
Copy link
Member

This follows color_eyre conventions and uses different sections to make error message prettier.

It's important to note that any error can manifest with this exact message (e.g. if mmseqs requires libraries and they are missing, or if mmseqs binary is not executable, if it segfaults etc.), so I made the suggestion message a little more generic (not assuming that the error is "file not found").

Image

This follows `color_eyre` conventions and uses different sections to make error message prettier.

It's important to note that any error can manifest with this exact message (e.g. if mmseqs requires libraries and they are missing, or if mmseqs binary is not executable, if it segfaults etc.), so I made the suggestion message a little more generic (not assuming that the error is "file not found").

![Image](https://github.com/user-attachments/assets/346bf3f9-db27-4c7f-a2d1-cd642c0d008f)
@ivan-aksamentov ivan-aksamentov merged commit a081392 into alignment-kernel-polish Jan 23, 2025
14 checks passed
@ivan-aksamentov ivan-aksamentov deleted the suggestion-1 branch January 23, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants