Remove user id from filepath #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalinAhlberg
force-pushed
the
feature/remove-user-from-filepath
branch
2 times, most recently
from
69a9ac5 to
c1c8db9
Compare
MalinAhlberg
force-pushed
the
feature/remove-user-from-filepath
branch
from
c1c8db9 to
1acdb43
Compare
MalinAhlberg
changed the base branch from
main
to
feature/do-not-leak-user-ids
MalinAhlberg
force-pushed
the
feature/remove-user-from-filepath
branch
from
3e4add6 to
6e3e439
Compare
jbygdell
approved these changes
Dec 16, 2024
aaperis
reviewed
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #1097 .
Description
The user's id is no longer stored in the database, so that it will never be shown to a user of download.
How to test
Note
The db schema version from #1123 should be set, but potentially in another PR.
The base of this PR is
feature/do-not-leak-user-ids, which is branched off main. I do not feel strongly about the naming of this branch, so feel totally free to have opinions.