This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Delay asset controller layout until frame is correct and layout is complete #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplete When presenting as a .FormSheet on iPad, the frame is not correct until just after `viewWillAppear:`. Moving the `scrollToItem:` code to viewDidAppear is too late, and viewWillAppear is too early. Dispatching to the main thread waits one run loop until the frame is update and the layout is complete without being visible to the user.
|
#168, #150, and #111 are duplicates of this fix, and this actually fixes a number of issues. @questbeat これらのいずれかをマージして問題を解決できるか (I'm having the same issue mentioned here: #148) |
|
Understood the problem. |
|
@questbeat Yay!! Thank you! 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When presenting as a .FormSheet on iPad, the frame is not correct until just after
viewWillAppear:. Moving thescrollToItem:code to viewDidAppear is too late, and viewWillAppear is too early. Dispatching to the main thread waits one run loop until the frame is update and the layout is complete without being visible to the user.possible fix for: #157 and #148