Fixed effects

src/game/scenes/world/effects/particles.ts

@@ -24,7 +24,7 @@ export class Particles implements IParticles {
   constructor(
     parent: IParticlesParent,
     {
-      key, position, texture, params, replay = true,
+      key, position, texture, params, dynamic, replay = false,
     }: ParticlesData,
   ) {
     this.scene = parent.scene;
@@ -47,18 +47,26 @@ export class Particles implements IParticles {
       position?.x ?? 0,
       position?.y ?? 0,
       texture,
-      params,
+      {
+        ...params,
+        follow: dynamic ? parent : undefined,
+      },
     );
-    this.emitter.setDepth(WORLD_DEPTH_EFFECT);
+    this.emitter.setDepth(
+      position?.y ?? parent?.y ?? WORLD_DEPTH_EFFECT,
+    );
+
+    this.destroy = this.destroy.bind(this);
+    this.update = this.update.bind(this);
+
+    this.parent.once(Phaser.GameObjects.Events.DESTROY, this.destroy);
 
-    this.parent.on(Phaser.GameObjects.Events.DESTROY, () => {
-      this.destroy();
-    });
+    if (dynamic) {
+      this.scene.events.on(Phaser.Scenes.Events.UPDATE, this.update);
+    }
 
     if (params.duration) {
-      this.emitter.on(Phaser.GameObjects.Particles.Events.COMPLETE, () => {
-        this.destroy();
-      });
+      this.emitter.once(Phaser.GameObjects.Particles.Events.COMPLETE, this.destroy);
     }
   }
 
@@ -67,5 +75,10 @@ export class Particles implements IParticles {
     this.emitter.destroy();
 
     this.parent.off(Phaser.GameObjects.Events.DESTROY, this.destroy);
+    this.scene.events.off(Phaser.Scenes.Events.UPDATE, this.update);
+  }
+
+  private update() {
+    this.emitter.setDepth(this.parent.depth);
   }
 }

src/game/scenes/world/entities/npc/npc.ts

@@ -107,9 +107,9 @@ export class NPC extends Sprite implements INPC {
       new Particles(this, {
         key: 'freeze',
         texture: ParticlesTexture.BIT_SOFT,
+        dynamic: true,
         params: {
           duration: lifespan,
-          follow: this,
           followOffset: this.getBodyOffset(),
           color: [0xffffff, 0x8cf9ff, 0x00f2ff],
           colorEase: 'quad.out',

src/game/scenes/world/entities/npc/variants/enemy/enemy.ts

@@ -260,8 +260,9 @@ export class Enemy extends NPC implements IEnemy {
     new Particles(this, {
       key: 'fire',
       texture: ParticlesTexture.BIT_SOFT,
+      dynamic: true,
+      replay: true,
       params: {
-        follow: this,
         followOffset: this.getBodyOffset(),
         duration,
         color: [0xfacc22, 0xf89800, 0xf83600, 0x9f0404],

src/game/scenes/world/entities/npc/variants/enemy/variants/telepath.ts

@@ -90,12 +90,11 @@ export class EnemyTelepath extends Enemy {
         enemy.live.addHealth(healthAmount);
 
         if (this.scene.game.isSettingEnabled(GameSettings.EFFECTS)) {
-          new Particles(this, {
+          new Particles(enemy, {
             key: 'regeneration',
             texture: ParticlesTexture.PLUS,
-            replay: false,
+            dynamic: true,
             params: {
-              follow: enemy,
               followOffset: {
                 x: 0,
                 y: -enemy.displayHeight,

src/game/scenes/world/entities/player.ts

@@ -684,8 +684,8 @@ export class Player extends Sprite implements IPlayer {
     this.dustEffect = new Particles(this, {
       key: 'dust',
       texture: ParticlesTexture.BIT,
+      dynamic: true,
       params: {
-        follow: this,
         followOffset: {
           x: 0,
           y: -this.gamut * this.scaleY * 0.5,

src/game/scenes/world/entities/shot/ball/ball.ts

@@ -121,8 +121,8 @@ export class ShotBall extends Phaser.Physics.Arcade.Image implements IShotBall {
       this.effect = new Particles(this, {
         key: 'glow',
         texture: ParticlesTexture.GLOW,
+        dynamic: true,
         params: {
-          follow: this,
           scale: 0.2 * this.scale,
           alpha: { start: 1.0, end: 0.0 },
           lifespan: 20000 / this.params.speed,

src/game/scenes/world/entities/shot/lazer.ts

@@ -105,17 +105,19 @@ export class ShotLazer extends Phaser.GameObjects.Line implements IShotLazer {
     }
 
     if (this.scene.game.isSettingEnabled(GameSettings.EFFECTS)) {
-      const lifespan = Math.min(100, this.displayWidth * 2);
+      const lifespan = this.target.displayWidth * 5;
+      const scale = Math.min(2.25, this.target.displayWidth / 18);
 
-      new Particles(this, {
+      new Particles(this.target, {
         key: 'lazer',
         texture: ParticlesTexture.BIT_SOFT,
+        dynamic: true,
         params: {
           duration: lifespan,
-          follow: this.target,
           followOffset: this.target.getBodyOffset(),
           lifespan: { min: lifespan / 2, max: lifespan },
-          scale: { start: 1.0, end: 0.25 },
+          scale: { start: scale, end: scale * 0.2 },
+          alpha: { start: 1.0, end: 0.0 },
           speed: 80,
           tint: 0xb136ff,
         },

src/game/scenes/world/entities/sprite.ts

@@ -353,16 +353,17 @@ export class Sprite extends Phaser.Physics.Arcade.Sprite implements ISprite {
     ) {
       return;
     }
+    const scale = Math.min(2.0, this.displayWidth / 22);
 
     new Particles(this, {
       key: 'blood',
       texture: ParticlesTexture.BIT_SOFT,
+      dynamic: true,
       params: {
         duration: 200,
-        follow: this,
         followOffset: this.getBodyOffset(),
         lifespan: { min: 100, max: 250 },
-        scale: { start: 1.0, end: 0.5 },
+        scale: { start: scale, end: scale * 0.25 },
         speed: 60,
         maxAliveParticles: 6,
         tint: 0xdd1e1e,

src/types/world/effects/particles.ts

@@ -17,7 +17,10 @@ export interface IParticles {
   destroy(): void
 }
 
-export interface IParticlesParent extends Phaser.GameObjects.GameObject {
+export interface IParticlesParent extends
+  Phaser.GameObjects.GameObject,
+  Phaser.GameObjects.Components.Transform,
+  Phaser.GameObjects.Components.Depth {
   readonly scene: IWorld
 
   /**
@@ -37,6 +40,7 @@ export type ParticlesData = {
   key?: string
   position?: PositionAtWorld
   texture: ParticlesTexture
+  dynamic?: boolean
   replay?: boolean
   params: Phaser.Types.GameObjects.Particles.ParticleEmitterConfig
 };