fix: if condition in composite action misbehaves with uses

[ChristopherHX]

Fixes #2426

tbt

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ EDITORCONFIG	editorconfig-checker	2		0	0.01s
✅ REPOSITORY	gitleaks	yes		no	2.35s
✅ REPOSITORY	git_diff	yes		no	0.01s
✅ REPOSITORY	grype	yes		no	9.69s
✅ REPOSITORY	secretlint	yes		no	1.05s
✅ REPOSITORY	trivy-sbom	yes		no	0.47s
✅ REPOSITORY	trufflehog	yes		no	5.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

[mergify]

@ChristopherHX this pull request has failed checks 🛠

[mergify]

@ChristopherHX this pull request has failed checks 🛠

[mergify]

@ChristopherHX this pull request has failed checks 🛠

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.72%. Comparing base (5a80a04) to head (45122a2).
Report is 118 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #2473       +/-   ##
===========================================
+ Coverage   61.56%   76.72%   +15.16%     
===========================================
  Files          53       62        +9     
  Lines        9002     8195      -807     
===========================================
+ Hits         5542     6288      +746     
+ Misses       3020     1343     -1677     
- Partials      440      564      +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChristopherHX]

After Trial and Error I hope there are no new regressions, added a test for the defect that is fixed here.

Workarounds for correct execution get's complicated, maybe a rewrite is needed.

[CharlieC3]

@ChristopherHX Thanks for submitting this! I can confirm this PR has fixed the problem I mentioned here. I have not noticed any regressions.

Not sure if I should give explicit approval here since I'm not a maintainer, but this seems fine to me.

[ChristopherHX]

Thank you for verifying my PR, not always are my changes working correctly and external testing feedback helps a lot

I hope this will help members of act to decide about this change.