Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests with validation errors were skipped #2496

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

ChristopherHX
Copy link
Contributor

Caution

Some tests were broken after workflow schema validation had been added, need to decide what to do and how this impacted merges

Copy link
Contributor

github-actions bot commented Oct 20, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.37s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 8.82s
✅ REPOSITORY secretlint yes no 1.15s
✅ REPOSITORY trivy-sbom yes no 0.11s
✅ REPOSITORY trufflehog yes no 4.48s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@ChristopherHX
Copy link
Contributor Author

This list is not short :(

--- FAIL: TestJobExecutor (1.76s)
    --- FAIL: TestJobExecutor/uses-github-empty (0.01s)
    --- FAIL: TestJobExecutor/uses-github-noref (0.01s)
    --- FAIL: TestJobExecutor/uses-github-short-sha (0.00s)
--- FAIL: TestRunEvent (691.62s)
    --- FAIL: TestRunEvent/shells/pwsh (0.00s)
    --- FAIL: TestRunEvent/shells/bash (0.00s)
    --- FAIL: TestRunEvent/shells/python (0.00s)
    --- FAIL: TestRunEvent/shells/sh (0.00s)
    --- FAIL: TestRunEvent/uses-composite-with-error (0.00s)
    --- FAIL: TestRunEvent/fail (0.00s)
    --- FAIL: TestRunEvent/job-container-invalid-credentials (0.00s)
    --- FAIL: TestRunEvent/matrix-exitcode (0.00s)
    --- FAIL: TestRunEvent/non-existent-action (0.00s)
    --- FAIL: TestRunEvent/job-status-check (0.00s)
    --- FAIL: TestRunEvent/if-expressions (0.00s)
    --- FAIL: TestRunEvent/actions-environment-and-context-tests (0.00s)
    --- FAIL: TestRunEvent/ensure-post-steps (0.00s)
    --- FAIL: TestRunEvent/path-handling (0.00s)
    --- FAIL: TestRunEvent/no-panic-on-invalid-composite-action (0.00s)
--- FAIL: TestRunEventHostEnvironment (12.71s)
    --- FAIL: TestRunEventHostEnvironment/shells/pwsh (0.00s)
    --- FAIL: TestRunEventHostEnvironment/shells/bash (0.00s)
    --- FAIL: TestRunEventHostEnvironment/shells/python (0.00s)
    --- FAIL: TestRunEventHostEnvironment/shells/sh (0.00s)
    --- FAIL: TestRunEventHostEnvironment/uses-composite-with-error (0.00s)
    --- FAIL: TestRunEventHostEnvironment/fail (0.00s)
    --- FAIL: TestRunEventHostEnvironment/non-existent-action (0.00s)
    --- FAIL: TestRunEventHostEnvironment/job-status-check (0.00s)
    --- FAIL: TestRunEventHostEnvironment/if-expressions (0.00s)
    --- FAIL: TestRunEventHostEnvironment/ensure-post-steps (0.00s)
    --- FAIL: TestRunEventHostEnvironment/inputs-via-env-context (0.00s)
    --- FAIL: TestRunEventHostEnvironment/no-panic-on-invalid-composite-action (0.00s)
--- FAIL: TestDryrunEvent (0.55s)
    --- FAIL: TestDryrunEvent/shells/pwsh (0.00s)
    --- FAIL: TestDryrunEvent/shells/bash (0.00s)
    --- FAIL: TestDryrunEvent/shells/python (0.00s)
    --- FAIL: TestDryrunEvent/shells/sh (0.00s)

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (5a80a04) to head (cb81f6b).
Report is 125 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2496       +/-   ##
===========================================
+ Coverage   61.56%   75.01%   +13.44%     
===========================================
  Files          53       62        +9     
  Lines        9002    10013     +1011     
===========================================
+ Hits         5542     7511     +1969     
+ Misses       3020     1936     -1084     
- Partials      440      566      +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 26, 2024
@ChristopherHX ChristopherHX marked this pull request as ready for review October 26, 2024 11:33
@ChristopherHX ChristopherHX requested a review from a team as a code owner October 26, 2024 11:33
@mergify mergify bot merged commit 2c0e3fe into master Oct 28, 2024
12 checks passed
@mergify mergify bot deleted the fix-tests-with-validation-errors-were-skipped branch October 28, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants