Merge pull request #37 from nenoNaninu/semconv_exception

Support semconv for exception
nenoNaninu · May 11, 2024 · 5b0442e · 5b0442e
2 parents 1cf7daf + 51f58a6
commit 5b0442e
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/AspNetCore.SignalR.OpenTelemetry/Internal/HubActivitySource.cs b/src/AspNetCore.SignalR.OpenTelemetry/Internal/HubActivitySource.cs
@@ -12,7 +12,7 @@ internal static class HubActivitySource
 
     internal static Activity? StartInvocationActivity(string hubName, string methodName, string? address)
     {
-        // https://github.com/open-telemetry/semantic-conventions/blob/v1.24.0/docs/rpc/rpc-spans.md#span-name
+        // https://github.com/open-telemetry/semantic-conventions/blob/v1.25.0/docs/rpc/rpc-spans.md#span-name
         var activity = ActivitySource.CreateActivity($"{hubName}/{methodName}", ActivityKind.Server);
 
         // Activity.IsAllDataRequested is same as TelemetrySpan.IsRecording in OpenTelemetry API.
@@ -23,7 +23,7 @@ internal static class HubActivitySource
             return null;
         }
 
-        // https://github.com/open-telemetry/semantic-conventions/blob/v1.24.0/docs/rpc/rpc-spans.md#common-attributes
+        // https://github.com/open-telemetry/semantic-conventions/blob/v1.25.0/docs/rpc/rpc-spans.md#common-attributes
         activity.SetTag("rpc.system", "signalr");
         activity.SetTag("rpc.service", hubName);
         activity.SetTag("rpc.method", methodName);
@@ -55,7 +55,11 @@ internal static void StopInvocationActivityError(Activity? activity, Exception e
         }
 
         activity.SetTag("otel.status_code", "ERROR");
-        activity.SetTag("signalr.hub.exception", exception.ToString());
+
+        // https://github.com/open-telemetry/semantic-conventions/blob/v1.25.0/docs/exceptions/exceptions-spans.md#attributes
+        activity.SetTag("exception.message", exception.Message);
+        activity.SetTag("exception.stacktrace", exception.StackTrace);
+        activity.SetTag("exception.type", exception.GetType().FullName);
     }
 }