fix: obfuscate password in log

neo4j-contrib · Sep 4, 2024 · 5523e41 · 5523e41
1 parent a7e28e1
commit 5523e41
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/kafka-connect-neo4j/src/main/kotlin/streams/kafka/connect/common/ConfigurationMigrator.kt b/kafka-connect-neo4j/src/main/kotlin/streams/kafka/connect/common/ConfigurationMigrator.kt
@@ -64,7 +64,7 @@ class ConfigurationMigrator(private val settings: Map<String, String>) {
         SERVER_URI to PropertyConverter("neo4j.uri") { settings[SERVER_URI] as String },
         AUTHENTICATION_TYPE to PropertyConverter("neo4j.authentication.type") { settings[AUTHENTICATION_TYPE] as String },
         AUTHENTICATION_BASIC_USERNAME to PropertyConverter("neo4j.authentication.basic.username") {settings[AUTHENTICATION_BASIC_USERNAME] as String},
-        AUTHENTICATION_BASIC_PASSWORD to PropertyConverter("neo4j.authentication.basic.password") {settings[AUTHENTICATION_BASIC_PASSWORD] as String},
+        AUTHENTICATION_BASIC_PASSWORD to PropertyConverter("neo4j.authentication.basic.password") {""},
         AUTHENTICATION_BASIC_REALM to PropertyConverter("neo4j.authentication.basic.realm") {settings[AUTHENTICATION_BASIC_REALM] as String},
         AUTHENTICATION_KERBEROS_TICKET to PropertyConverter("neo4j.authentication.kerberos.ticket") {settings[AUTHENTICATION_KERBEROS_TICKET] as String},
         BATCH_SIZE to PropertyConverter("neo4j.batch-size") {settings[BATCH_SIZE] as String},

diff --git a/...a-connect-neo4j/src/test/kotlin/streams/kafka/connect/common/ConfigurationMigratorTest.kt b/...a-connect-neo4j/src/test/kotlin/streams/kafka/connect/common/ConfigurationMigratorTest.kt
@@ -129,7 +129,7 @@ class ConfigurationMigratorTest {
     assertEquals(migratedConfig["value.converter.schema.registry.url"], "http://schema-registry:8081")
     assertEquals(migratedConfig["neo4j.uri"], "bolt://neo4j:7687")
     assertEquals(migratedConfig["neo4j.authentication.basic.username"], "neo4j")
-    assertEquals(migratedConfig["neo4j.authentication.basic.password"], "password")
+    assertEquals(migratedConfig["neo4j.authentication.basic.password"], "")
     assertEquals(migratedConfig["neo4j.query.poll-interval"], "5000ms")
     assertEquals(migratedConfig["neo4j.query.streaming-property"], "timestamp")
     assertEquals(
@@ -165,7 +165,7 @@ class ConfigurationMigratorTest {
     assertEquals(migratedConfig["errors.log.include.messages"], "true")
     assertEquals(migratedConfig["neo4j.uri"], "bolt://neo4j:7687")
     assertEquals(migratedConfig["neo4j.authentication.basic.username"], "neo4j")
-    assertEquals(migratedConfig["neo4j.authentication.basic.password"], "password")
+    assertEquals(migratedConfig["neo4j.authentication.basic.password"], "")
     assertEquals(migratedConfig["neo4j.cypher.topic.my-topic"], "MERGE (p:Person{name: event.name, surname: event.surname}) MERGE (f:Family{name: event.surname}) MERGE (p)-[:BELONGS_TO]->(f)")
   }