Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update configuration migration properties #650

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

dhrudevalia
Copy link

@dhrudevalia dhrudevalia commented Sep 3, 2024

Fixes configuration migration for missed properties and removed properties.

Proposed Changes (Mandatory)

A brief list of proposed changes in order to fix the issue:

  • Remove neo4j.retry.max.attemps configuration option as it has been removed in the 5.1 release of the connector
  • Add configuration migration for connector.class to updated class package for 5.1 connector
  • Update tests

Example

image

@dhrudevalia dhrudevalia requested a review from a team as a code owner September 3, 2024 12:40
@dhrudevalia dhrudevalia self-assigned this Sep 3, 2024
@dhrudevalia dhrudevalia requested a review from ali-ince September 3, 2024 13:28
Copy link
Contributor

@ali-ince ali-ince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhrudevalia dhrudevalia enabled auto-merge (squash) September 4, 2024 09:20
@dhrudevalia dhrudevalia merged commit a7e28e1 into 5.0 Sep 4, 2024
5 checks passed
@dhrudevalia dhrudevalia deleted the updateMigrationProperties branch September 4, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants