Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async support to neomodel #783

Merged
merged 59 commits into from
Apr 9, 2024
Merged

Add async support to neomodel #783

merged 59 commits into from
Apr 9, 2024

Conversation

mariusconjeaud
Copy link
Collaborator

@mariusconjeaud mariusconjeaud commented Feb 5, 2024

Introducing support for asynchronous programming to neomodel required to introduce some breaking changes:

  • Replace from neomodel import db with from neomodel.sync_.core import db
  • config.AUTO_INSTALL_LABELS has been removed. Please use the neomodel_install_labels command instead.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 91.46730% with 214 lines in your changes are missing coverage. Please review.

Project coverage is 82.02%. Comparing base (4bd6302) to head (8bd7aa0).

❗ Current head 8bd7aa0 differs from pull request most recent head ce3a1cf. Consider uploading reports for the commit ce3a1cf to get more accurate results

Files Patch % Lines
neomodel/async_/match.py 90.16% 54 Missing ⚠️
neomodel/async_/core.py 93.43% 42 Missing ⚠️
neomodel/sync_/core.py 93.43% 42 Missing ⚠️
neomodel/contrib/async_/semi_structured.py 26.47% 25 Missing ⚠️
neomodel/contrib/spatial_properties.py 9.09% 20 Missing ⚠️
neomodel/async_/relationship_manager.py 92.01% 19 Missing ⚠️
neomodel/sync_/match.py 90.00% 3 Missing ⚠️
neomodel/async_/relationship.py 97.59% 2 Missing ⚠️
neomodel/scripts/neomodel_install_labels.py 0.00% 2 Missing ⚠️
neomodel/scripts/neomodel_remove_labels.py 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##           rc/5.3.0     #783      +/-   ##
============================================
- Coverage     89.43%   82.02%   -7.41%     
============================================
  Files            22       32      +10     
  Lines          2669     4429    +1760     
============================================
+ Hits           2387     3633    +1246     
- Misses          282      796     +514     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariusconjeaud
Copy link
Collaborator Author

!!!!!!! The integration tests pipeline was fully successful for the first time since starting the work on async !!!!!!!

It should be ready soon !

Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
16.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@mariusconjeaud mariusconjeaud merged commit ef50a33 into rc/5.3.0 Apr 9, 2024
30 of 31 checks passed
@mariusconjeaud mariusconjeaud deleted the task/async branch May 27, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants