Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DateProperty bug in inspection script #797

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix DateProperty bug in inspection script #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a37d127
Fix DateProperty but in inspection script
May 22, 2024
937ed29
Fix test data files
May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions neomodel/scripts/neomodel_inspect_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ def parse_prop_class(prop_type):
elif prop_type == "BOOLEAN":
_import = "BooleanProperty"
prop_class = f"{_import}("
elif prop_type == "DATE":
_import = "DateProperty"
prop_class = f"{_import}("
elif prop_type == "DATE_TIME":
_import = "DateTimeProperty"
prop_class = f"{_import}("
Expand Down
3 changes: 2 additions & 1 deletion test/data/neomodel_inspect_database_output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from neomodel import StructuredNode, StringProperty, RelationshipTo, StructuredRel, ZeroOrOne, ArrayProperty, FloatProperty, BooleanProperty, DateTimeProperty, IntegerProperty
from neomodel import StructuredNode, StringProperty, RelationshipTo, StructuredRel, ZeroOrOne, ArrayProperty, FloatProperty, BooleanProperty, DateProperty, DateTimeProperty, IntegerProperty
from neomodel.contrib.spatial_properties import PointProperty

class ScriptsTestNode(StructuredNode):
Expand All @@ -19,6 +19,7 @@ class EveryPropertyTypeNode(StructuredNode):
boolean_property = BooleanProperty()
point_property = PointProperty(crs='wgs-84')
string_property = StringProperty()
date_property = DateProperty()
datetime_property = DateTimeProperty()
integer_property = IntegerProperty()

Expand Down
3 changes: 2 additions & 1 deletion test/data/neomodel_inspect_database_output_light.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from neomodel import StructuredNode, StringProperty, RelationshipTo, ArrayProperty, FloatProperty, BooleanProperty, DateTimeProperty, IntegerProperty
from neomodel import StructuredNode, StringProperty, RelationshipTo, ArrayProperty, FloatProperty, BooleanProperty, DateProperty, DateTimeProperty, IntegerProperty
from neomodel.contrib.spatial_properties import PointProperty

class ScriptsTestNode(StructuredNode):
Expand All @@ -14,6 +14,7 @@ class EveryPropertyTypeNode(StructuredNode):
boolean_property = BooleanProperty()
point_property = PointProperty(crs='wgs-84')
string_property = StringProperty()
date_property = DateProperty()
datetime_property = DateTimeProperty()
integer_property = IntegerProperty()

Expand Down
3 changes: 2 additions & 1 deletion test/data/neomodel_inspect_database_output_pre_5_7.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from neomodel import StructuredNode, StringProperty, RelationshipTo, StructuredRel, ZeroOrOne, ArrayProperty, FloatProperty, BooleanProperty, DateTimeProperty, IntegerProperty
from neomodel import StructuredNode, StringProperty, RelationshipTo, StructuredRel, ZeroOrOne, ArrayProperty, FloatProperty, BooleanProperty, DateProperty, DateTimeProperty, IntegerProperty
from neomodel.contrib.spatial_properties import PointProperty

class ScriptsTestNode(StructuredNode):
Expand All @@ -19,6 +19,7 @@ class EveryPropertyTypeNode(StructuredNode):
boolean_property = BooleanProperty()
point_property = PointProperty(crs='wgs-84')
string_property = StringProperty()
date_property = DateProperty()
datetime_property = DateTimeProperty()
integer_property = IntegerProperty()

Expand Down
3 changes: 2 additions & 1 deletion test/data/neomodel_inspect_database_output_pre_5_7_light.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from neomodel import StructuredNode, StringProperty, RelationshipTo, ArrayProperty, FloatProperty, BooleanProperty, DateTimeProperty, IntegerProperty
from neomodel import StructuredNode, StringProperty, RelationshipTo, ArrayProperty, FloatProperty, BooleanProperty, DateProperty, DateTimeProperty, IntegerProperty
from neomodel.contrib.spatial_properties import PointProperty

class ScriptsTestNode(StructuredNode):
Expand All @@ -14,6 +14,7 @@ class EveryPropertyTypeNode(StructuredNode):
boolean_property = BooleanProperty()
point_property = PointProperty(crs='wgs-84')
string_property = StringProperty()
date_property = DateProperty()
datetime_property = DateTimeProperty()
integer_property = IntegerProperty()

Expand Down
1 change: 1 addition & 0 deletions test/test_scripts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ def test_neomodel_inspect_database(script_flavour):
CREATE (:EveryPropertyTypeNode {
string_property: "Hello World",
boolean_property: true,
date_property: date("2020-01-01"),
datetime_property: datetime("2020-01-01T00:00:00.000Z"),
integer_property: 1,
float_property: 1.0,
Expand Down
Loading