-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow for table syntax like on github, plus with tests #40
Conversation
This a nice PR and something I'll definitely consider. I'll look over it properly when I have some spare time this week. I didn't even realise that GFM had this support and I can't find it documented. My original plan was to add better support for ignoring elements (e.g. Oh, and thanks for taking the time in doing this. I have no problems with adding GFM support. I'll probably look at documenting these explicitly in the README file as and when they're added, maybe allowing an option to enable/disable GFM support. |
+1 @eleith - You rock, I need this feature for a client - 123 tables to convert. Thanks so much. I would love to see it easily available :-) |
Just an update that I'm still considering how this could best be done (i.e. GFM support as a whole) as I realise this PR has been sitting for a while. Honestly, it will most likely be on the other side of the holidays before I work it out as I'm busy swamped right now. |
I have started using @eleith's fork and it works for a subset of my table conversations. So, I'm starting to see some of the wider issues :-) Also, I am using showdown and the current table extension doesn't support GFM suggesting again that table support could get more complex. Finally, such table support for me really needs the ability to leave the html table in place. So if that just increased the job but it is what I am currently needing to complete a real migration of a system. Cheers |
This is why I want to make sure GFM support is implemented correctly on a framework level. I'm mainly think about a single I'm already planning #11 which would allow you table HTML to be untouched by the parser. |
Any plans to integrate this one? |
Honestly, I've not had as much time to work on this project recently but I am hoping to get back to it very soon. The current implementation (hopefully) covers core Markdown so I'm reluctant to let GFM features creep in without some kind of control. The simplest approach will be an option to enable all/specific GFM features. |
any plans to support this? |
Yes, I still plan on supporting tables and other GFM syntax, however, I want to be able to do so correctly. As I said on the other issue; I haven't had much time to work on this project due to other commitments but that I still have a lot planned for this project. This includes pluggable extensions which would involve a large rewrite to make the code more modular, separate out the existing logic into built-in extensions (e.g. for each tag supported) and then to also support presents (bundles of plugins -- e.g. GFM) which would be external from the main project. |
Sorry for taking so so very long to address this. I finally got around to doing the massive rewrite of this library that I wanted to. It's been renamed Europa and it's totally changed. Unfortunately, Europa still doesn't come with table support built in. However, I have laid the groundwork for it. Europa is fully pluggable so adding support for new tags is super easy (see Plugins). As part of the rewrite I split the the project into multiple modules to simplify everything. This means that all logic now exists within europa-core. This is where all of the built-in plugins now reside. I'm currently contemplating splitting these out further into their own micro-modules, but I want to have a good framework and boilerplate in place to make maintaining them as simple as possible. Once that's done I do plan on creating my own GFM plugins (with a GFM preset) that will make getting full GFM support easy and fully opt-in. Feel free to create your own plugin, but know that I plan on getting around to doing this soon and maintain momentum on progress for this library. I'm closing this PR now as it's no longer valid for this repo. If you still use Sorry again for the massive delay. |
if you were interested in GFM style table syntax (example: https://gist.github.com/eleith/76c0bb6f0b05f797d00d)
this pull requests provides support for that (and tests to prove it too)
this is a great project and i'm pairing it with marked.js to provide html <--> markdown conversion. since marked.js supports the table syntax, i wanted to compliment it with support in the markdown to html converter too.
if you are interested, let me know how i can help (this project's code was well written enough that adding support was very straightforward!).
if you want to keep the markdown supported simple, no worries!