Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change chatbots to use websocket #27

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Change chatbots to use websocket #27

wants to merge 19 commits into from

Conversation

yugoccp
Copy link
Collaborator

@yugoccp yugoccp commented May 24, 2022

Work in progress PR.

  • Created connected-worlds-hub to act as websocket hub
  • Changed quarkus-world to interact using websockets
  • Changed helidon-world to interact using websockets
  • In progress change roberta-world to use websocket
  • In progress change docker-runner.sh to run websocket solution

@yugoccp yugoccp added the spike label May 24, 2022
@yugoccp yugoccp changed the title Feature/websocket Change chatbots to use websocket May 24, 2022
@yugoccp
Copy link
Collaborator Author

yugoccp commented May 24, 2022

@neomatrix369 after seeing changes here, it poluted too much the PR. Do you think is better to make smaller adds into new cleaner branch instead of using this spike branch to merge?

I've recreated new projects for quarkus and helidon chatbots to get the correct versions to work with websockets. Since I know them now, I could simply update the current projects...

@neomatrix369
Copy link
Owner

If you can add a screen-shot or two of a working version of this PR that would be great, no worries if its not there 100%

@neomatrix369 neomatrix369 marked this pull request as draft May 25, 2022 21:08
@neomatrix369 neomatrix369 force-pushed the master branch 2 times, most recently from d108aab to 99feaef Compare May 25, 2022 21:57
@yugoccp yugoccp added enhancement New feature or request help wanted Extra attention is needed labels May 26, 2022
@yugoccp
Copy link
Collaborator Author

yugoccp commented May 26, 2022

Working screenshot example

Screen Shot 2022-05-26 at 01 10 07

@neomatrix369
Copy link
Owner

Working screenshot example

Screen Shot 2022-05-26 at 01 10 07

Loving the look and feel of it

Great work @yugoccp

@neomatrix369 neomatrix369 self-requested a review May 31, 2022 22:07
@neomatrix369
Copy link
Owner

This is the right time to now pluck the smallest change to make one bot work with websocket and the rest on REST API - then we can close this PR without merging and review and work on the other one. And slowly we can take parts of this PR and make new ones till we have merged them all - just like we discussed the last time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed spike
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants