-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change chatbots to use websocket #27
base: master
Are you sure you want to change the base?
Conversation
@neomatrix369 after seeing changes here, it poluted too much the PR. Do you think is better to make smaller adds into new cleaner branch instead of using this spike branch to merge? I've recreated new projects for quarkus and helidon chatbots to get the correct versions to work with websockets. Since I know them now, I could simply update the current projects... |
…sion instead of broadcast
If you can add a screen-shot or two of a working version of this PR that would be great, no worries if its not there 100% |
d108aab
to
99feaef
Compare
…nd add banner to explicit websocket version
…lemented with websocket version
…it websocket mode
…r to explicit websocket mode
Loving the look and feel of it Great work @yugoccp |
This is the right time to now pluck the smallest change to make one bot work with websocket and the rest on REST API - then we can close this PR without merging and review and work on the other one. And slowly we can take parts of this PR and make new ones till we have merged them all - just like we discussed the last time. |
Work in progress PR.