Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to the docker login action #1

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

fedordikarev
Copy link
Collaborator

@fedordikarev fedordikarev commented Jan 23, 2025

Ref: https://github.com/neondatabase/cloud/issues/20164

Current problem:

  • occasionally we hit 502 from hub.docker.com
  • docker/login-action doesn't have retry mechanism
  • so we either have to fail the whole Workflow
  • or we have to restart whole Workflow

that mechanism at the same time should be conservative, not adding extra unneeded load to DockerHub or another Registry, so for example we shouldn't retry "Bad credentials", we should have timeouts, and reasonable max_attempts

Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant