Softer checks for compiler warnings in CI #1842
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently introduced check for the number of compiler warnings appears too strict, since in particular the inclusion of external libraries can lead to large numbers of warnings with the exact number depending on details of header file inclusion. This leads to failing CI tests for rather obscure reasons and is thus counterproductive.
This PR addresses this in two ways:
@lekshmideepu This will solve the problem causing #5437.5 to fail for PR #1839.