Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encode error of help text. #1987

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Fix encode error of help text. #1987

merged 2 commits into from
Mar 22, 2021

Conversation

babsey
Copy link
Contributor

@babsey babsey commented Mar 22, 2021

After merging PR #1926 I tested getting help via nest-server and I got error:
'ascii' codec can't decode byte 0xe2 in position 13: ordinal not in range(128)

This PR should fix this encoding error.

@heplesser heplesser requested a review from jougs March 22, 2021 14:00
heplesser
heplesser requested changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just consistency in hyphenation ;).

pynest/nest/lib/hl_api_helper.py Outdated Show resolved Hide resolved
jougs
jougs approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@heplesser heplesser merged commit 43860f3 into nest:master Mar 22, 2021
@babsey babsey deleted the help-encode branch March 24, 2021 11:37
@jougs jougs added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation labels May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babsey @heplesser @jougs