-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify neuron + synapse as hybrid dynamical systems models; clarify integration loop sequence #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e47949
to
48d9b9f
Compare
…pecific variables
d174345
to
f87f135
Compare
f87f135
to
766397e
Compare
|
…alization paradigm introduced in NEST 3.6
…tegrate_specific_odes
…clean up module (re)loading in tests after NEST 3.7 module reloading feature
…clean up module (re)loading in tests after NEST 3.7 module reloading feature
Thanks for the heroic review and comments! The remainder of the comments will be addressed in #1025 to keep the size and reviewability of this PR manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #440
Fixes #192
Fixes #938
Fixes #189
Fixes #598
For the rendered documentation, see https://nestml-sandbox.readthedocs.io/
integrate_odes()
integrate_odes()
is called, and in the case of NEST Simulator, are always assumed to be processed after the subthreshold dynamics but before the condition checks; hence the observed value will always be the one "just after" the instantaneous change due to the spike eventTo do
emit_spike()
anddeliver_spike()
. How to deal with parameters of the spike event itself? Spun off to Adding attributes to spike events #946.onEvent
blocks in neuronsupdate
block intoupdate
,onCondition
blocks)nest_integration_test.py
priority
attribute for event handlersintegrate_odes()
with arguments for now)// B_.spike_input_received_[{{ inport.upper() }} - MIN_SPIKE_RECEPTOR] = false;
inNeuronClass.jinja2
{# for neuron-synapse co-generation: separate integrator for the emulated/dummy integrate_odes() below in this template #}
inNeuronClass.jinja2
extras/nestml_model_doc_generator.py
-- maybe something inresouces_autodoc
?