Add feature "sort" #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature indicates support for "locale", "sort-by", and "direction". Fixes: #28
|
The "direction" query parameter should be in the required set to implement. |
kwatsen
requested changes
Feb 6, 2025
ietf-list-pagination.yang
Outdated
| feature sort { | ||
| description | ||
| 'This feature indicates that the parameters "locale", "sort-by", | ||
| and "direction" are supported.'; |
There was a problem hiding this comment.
This line needs to be updated too.
| @@ -112,6 +119,7 @@ module ietf-list-pagination { | |||
| } | |||
|
|
|||
| md:annotation locale { | |||
| if-feature "sort"; | |||
There was a problem hiding this comment.
Not specific to this line, my comment applies to other if-feature statements as well:
Should sort be in double-quotes?
There was a problem hiding this comment.
In RFC 7950 complex if-feature statements are double quoted
and simple (i.e. single word) are not.
In RFC 8639 simple if-feature statements are double quoted
FWIW.
Should the double quotes be removed?
I don't have a strong opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature indicates support for "locale", "sort-by", and "direction".
Fixes: #28