TYPO3 v13 compatibility #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @marekskopal , thank you very much for your PR. Can you please be so kind and fix the reported CS issues? (And remove PHP 8.1 in the workflows?) Thank you very much. |
CybotTM
approved these changes
Nov 21, 2024
|
Hi @marekskopal , Sorry to bother you again, ext_emconf.php must also be adapted analogously to composer.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TYPO3 v13 compatibility
Closes #303
This pull request includes several changes related to PHP version support and refactoring of image processing in controllers. The most important changes include updating PHP versions in workflows, modifying the
RteImagePreviewRendererandImageLinkRenderingControllerclasses, and removing theMagicImageServicedependency.PHP Version Updates:
.github/workflows/phpcs.yml: Removed PHP 8.1 from the testing matrix..github/workflows/phpstan.yml: Removed PHP 8.1 from the testing matrix..github/workflows/testing.yml: Removed PHP 8.1 from the testing matrix.Refactoring
RteImagePreviewRenderer:Classes/Backend/Preview/RteImagePreviewRenderer.php: Changed the class to extendStandardContentPreviewRendererinstead ofTextPreviewRenderer.Refactoring
ImageLinkRenderingController:Classes/Controller/ImageLinkRenderingController.php: Removed the dependency onMagicImageServiceand addedProcessedFilefor image processing.Classes/Controller/ImageLinkRenderingController.php: IntroducedServerRequestInterfaceto get lazy loading configuration.Refactoring
ImageRenderingController:Classes/Controller/ImageRenderingController.php: Removed the dependency onMagicImageServiceand addedProcessedFilefor image processing.Classes/Controller/ImageRenderingController.php: IntroducedServerRequestInterfaceto get lazy loading configuration.Refactoring
SelectImageController:Classes/Controller/SelectImageController.php: Removed the dependency onMagicImageServiceand addedProcessedFilefor image processing.