netteForms: do not propagate 'submit' event further when the form is invalid #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in https://forum.nette.org/cs/36618-duplicitni-dialog-netteformsmodal-s-ajaxem-naja-js, when somebody uses netteForms and Naja (>= 3.2) together, and netteForms are loaded (and auto-initialized) before Naja, both libraries consecutively trigger the form validation, which results in duplicate dialogs when there are validation errors.
This change prevents the
submitevent from propagating even to other listeners attached to the same form and event.