Merge pull request #2284 from jimklimov/issue-2275-cleanup

Some generic codebase/recipe clean-up per recent investigation
networkupstools · Jan 29, 2024 · 1f9ed56 · 1f9ed56
2 parents 4c6459b + d170642
commit 1f9ed56
Show file tree

Hide file tree

Showing 20 changed files with 34 additions and 28 deletions.
diff --git a/Makefile.am b/Makefile.am
@@ -1,8 +1,5 @@
 # top-level Makefile for NUT
 
-# include directory for aclocal
-ACLOCAL_AMFLAGS = -I m4
-
 # Export certain values for ccache which NUT ci_build.sh can customize,
 # to facilitate developer iteration re-runs of "make" later.
 # At least GNU and BSD make implementations are okay with this syntax.
@@ -12,6 +9,9 @@ ACLOCAL_AMFLAGS = -I m4
 @NUT_AM_MAKE_CAN_EXPORT@export CCACHE_PATH=@CCACHE_PATH@
 @NUT_AM_MAKE_CAN_EXPORT@export PATH=@PATH_DURING_CONFIGURE@
 
+# include directory for aclocal
+ACLOCAL_AMFLAGS = -I m4
+
 # subdirectories to build and distribute. The order matters, as
 # several subdirectories depend on stuff in "common" or tools being built first
 SUBDIRS = include common clients conf data docs drivers tools \

diff --git a/clients/Makefile.am b/clients/Makefile.am
@@ -1,5 +1,4 @@
 # Network UPS Tools: clients
-EXTRA_DIST =
 
 # Export certain values for ccache which NUT ci_build.sh can customize,
 # to facilitate developer iteration re-runs of "make" later.
@@ -10,6 +9,8 @@ EXTRA_DIST =
 @NUT_AM_MAKE_CAN_EXPORT@export CCACHE_PATH=@CCACHE_PATH@
 @NUT_AM_MAKE_CAN_EXPORT@export PATH=@PATH_DURING_CONFIGURE@
 
+EXTRA_DIST =
+
 # nutclient.cpp for some legacy reason (maybe initial detached development?)
 # optionally includes "common.h" with the NUT build setup - and this option
 # was never triggered in fact, not until pushed through command line like this:

diff --git a/common/Makefile.am b/common/Makefile.am
@@ -1,12 +1,5 @@
 # Network UPS Tools: common
 
-AM_CFLAGS = -I$(top_srcdir)/include
-AM_LDFLAGS = -no-undefined
-EXTRA_DIST =
-
-noinst_LTLIBRARIES = libparseconf.la libcommon.la libcommonclient.la
-libparseconf_la_SOURCES = parseconf.c
-
 # Export certain values for ccache which NUT ci_build.sh can customize,
 # to facilitate developer iteration re-runs of "make" later.
 # At least GNU and BSD make implementations are okay with this syntax.
@@ -16,6 +9,13 @@ libparseconf_la_SOURCES = parseconf.c
 @NUT_AM_MAKE_CAN_EXPORT@export CCACHE_PATH=@CCACHE_PATH@
 @NUT_AM_MAKE_CAN_EXPORT@export PATH=@PATH_DURING_CONFIGURE@
 
+AM_CFLAGS = -I$(top_srcdir)/include
+AM_LDFLAGS = -no-undefined
+EXTRA_DIST =
+
+noinst_LTLIBRARIES = libparseconf.la libcommon.la libcommonclient.la
+libparseconf_la_SOURCES = parseconf.c
+
 # do not hard depend on '../include/nut_version.h', since it blocks
 # 'dist', and is only required for actual build, in which case
 # BUILT_SOURCES (in ../include) will ensure nut_version.h will

diff --git a/data/html/Makefile.am b/data/html/Makefile.am
@@ -1,4 +1,5 @@
 # Network UPS Tools: data/html
+
 # install these only if configured --with-cgi
 if WITH_CGI
  dist_html_DATA = index.html bottom.html nut-banner.png

diff --git a/drivers/apc-ats-mib.c b/drivers/apc-ats-mib.c
@@ -24,7 +24,7 @@
 
 #include "apc-ats-mib.h"
 
-#define APC_ATS_MIB_VERSION  "0.6"
+#define APC_ATS_MIB_VERSION  "0.60"
 
 #define APC_ATS_SYSOID       ".1.3.6.1.4.1.318.1.3.11"
 #define APC_ATS_OID_MODEL_NAME ".1.3.6.1.4.1.318.1.1.8.1.5.0"

diff --git a/drivers/apc-epdu-mib.c b/drivers/apc-epdu-mib.c
@@ -23,7 +23,7 @@
 
 #include "apc-epdu-mib.h"
 
-#define APC_EPDU_MIB_VERSION  "0.1"
+#define APC_EPDU_MIB_VERSION  "0.10"
 
 #define APC_EPDU_MIB_SYSOID   ".1.3.6.1.4.1.318.1.3.4.9"
 

diff --git a/drivers/apc-pdu-mib.c b/drivers/apc-pdu-mib.c
@@ -23,7 +23,7 @@
 
 #include "apc-pdu-mib.h"
 
-#define APC_PDU_MIB_VERSION  "0.4"
+#define APC_PDU_MIB_VERSION  "0.40"
 
 #define APC_PDU_MIB_SYSOID_RPDU      ".1.3.6.1.4.1.318.1.3.4.4"
 #define APC_PDU_MIB_SYSOID_RPDU2     ".1.3.6.1.4.1.318.1.3.4.5"

diff --git a/drivers/bestpower-mib.c b/drivers/bestpower-mib.c
@@ -22,7 +22,7 @@
 
 #include "bestpower-mib.h"
 
-#define BESTPOWER_MIB_VERSION		"0.4"
+#define BESTPOWER_MIB_VERSION		"0.40"
 #define BESTPOWER_OID_MODEL_NAME	".1.3.6.1.4.1.2947.1.1.2.0"
 
 /*

diff --git a/drivers/delta_ups-mib.c b/drivers/delta_ups-mib.c
@@ -25,7 +25,7 @@
 
 #include "delta_ups-mib.h"
 
-#define DELTA_UPS_MIB_VERSION  "0.5"
+#define DELTA_UPS_MIB_VERSION  "0.50"
 
 #define DELTA_UPS_SYSOID       ".1.3.6.1.4.1.2254.2.4"
 

diff --git a/drivers/eaton-pdu-nlogic-mib.c b/drivers/eaton-pdu-nlogic-mib.c
@@ -24,7 +24,7 @@
 
 #include "eaton-pdu-nlogic-mib.h"
 
-#define EATON_PDU_NLOGIC_MIB_VERSION  "0.1"
+#define EATON_PDU_NLOGIC_MIB_VERSION  "0.10"
 
 #define EATON_PDU_NLOGIC_SYSOID       ".1.3.6.1.4.1.534.7.1"
 

diff --git a/drivers/eaton-pdu-pulizzi-mib.c b/drivers/eaton-pdu-pulizzi-mib.c
@@ -42,7 +42,7 @@
 
 /* Pulizzi Switched ePDU */
 
-#define EATON_PULIZZI_SW_MIB_VERSION	"0.5"
+#define EATON_PULIZZI_SW_MIB_VERSION	"0.50"
 
 #define PULIZZI_SW_OID_MIB			".1.3.6.1.4.1.20677.3.1.1"
 #define PULIZZI_SW_OID_MODEL_NAME		".1.3.6.1.4.1.20677.2.1.1.0"

diff --git a/drivers/emerson-avocent-pdu-mib.c b/drivers/emerson-avocent-pdu-mib.c
@@ -25,7 +25,7 @@
 
 #include "emerson-avocent-pdu-mib.h"
 
-#define EMERSON_AVOCENT_MIB_VERSION		"1.3"
+#define EMERSON_AVOCENT_MIB_VERSION		"1.30"
 #define EMERSON_AVOCENT_SYSOID			".1.3.6.1.4.1.10418.17.1.7"
 #define EMERSON_AVOCENT_OID_MODEL_NAME	".1.3.6.1.4.1.10418.17.2.1.2.0"
 

diff --git a/drivers/hpe-pdu3-cis-mib.c b/drivers/hpe-pdu3-cis-mib.c
@@ -21,7 +21,7 @@
 
 #include "hpe-pdu3-cis-mib.h"
 
-#define HPE_PDU3_CIS_MIB_VERSION  "0.1"
+#define HPE_PDU3_CIS_MIB_VERSION  "0.10"
 
 #define HPE_PDU3_CIS_SYSOID       ".1.3.6.1.4.1.232.165.11"
 #define HPE_PDU3_OID_MODEL_NAME	".1.3.6.1.4.1.232.165.11.1.2.1.3.1"

diff --git a/drivers/huawei-mib.c b/drivers/huawei-mib.c
@@ -21,7 +21,7 @@
 
 #include "huawei-mib.h"
 
-#define HUAWEI_MIB_VERSION  "0.4"
+#define HUAWEI_MIB_VERSION  "0.40"
 
 #define HUAWEI_SYSOID       ".1.3.6.1.4.1.8072.3.2.10"
 #define HUAWEI_UPSMIB       ".1.3.6.1.4.1.2011"

diff --git a/drivers/raritan-pdu-mib.c b/drivers/raritan-pdu-mib.c
@@ -25,7 +25,7 @@
 
 #include "raritan-pdu-mib.h"
 
-#define RARITAN_MIB_VERSION	"0.8"
+#define RARITAN_MIB_VERSION	"0.80"
 
 /* Raritan MIB
  * this one uses the same MIB as Eaton Revelation,

diff --git a/drivers/raritan-px2-mib.c b/drivers/raritan-px2-mib.c
@@ -23,7 +23,7 @@
 
 #include "raritan-px2-mib.h"
 
-#define RARITAN_PX2_MIB_VERSION  "0.4"
+#define RARITAN_PX2_MIB_VERSION  "0.40"
 
 #define RARITAN_PX2_MIB_SYSOID     ".1.3.6.1.4.1.13742.6"
 #define RARITAN_PX2_OID_MODEL_NAME ".1.3.6.1.4.1.13742.6.3.2.1.1.3.1"

diff --git a/drivers/xppc-mib.c b/drivers/xppc-mib.c
@@ -24,7 +24,7 @@
 
 #include "xppc-mib.h"
 
-#define XPPC_MIB_VERSION  "0.4"
+#define XPPC_MIB_VERSION  "0.40"
 
 #define XPPC_SYSOID       ".1.3.6.1.4.1.935"
 

diff --git a/scripts/python/module/Makefile.am b/scripts/python/module/Makefile.am
@@ -25,7 +25,7 @@ GENERATED_DIST = dist build *.egg-info
 GENERATED_SRC  = PyNUTClient README.txt LICENSE-GPL3
 
 # These are normally generated by a NUT build, but if we want to iterate
-# specifically PyNUTClient packaging - `make clean dist` should do it here:
+# specifically PyNUTClient packaging - `make veryclean dist` should do it here:
 GENERATED_PY   = test_nutclient.py PyNUT.py setup.py
 
 # (Re-)generate files normally made by `configure` from .in templates
@@ -40,13 +40,16 @@ $(GENERATED_DIST): .pypi-dist
 clean-local:
 	rm -rf $(GENERATED_SRC) $(GENERATED_DIST)
 	rm -f .pypi-src .pypi-dist*
+
+veryclean: clean
 	rm -f $(GENERATED_PY)
 
 # Python test envs take a while to populate, so maybe better not clean
 # them too enthusiastically. Can revise (move to "clean-local") later,
 # if this choice proves a problem.
 distclean-local:
 	rm -rf .tox
+	rm -f $(GENERATED_PY)
 
 MAINTAINERCLEANFILES = Makefile.in .dirstamp .pypi-tools*
 

diff --git a/scripts/subdriver/gen-snmp-subdriver.sh b/scripts/subdriver/gen-snmp-subdriver.sh
@@ -10,7 +10,7 @@
 # Copyright (C)
 # 2011 - 2012 Arnaud Quette <[email protected]>
 # 2015 - 2022 Eaton (author: Arnaud Quette <[email protected]>)
-# 2011 - 2022 Jim Klimov <[email protected]>
+# 2011 - 2024 Jim Klimov <[email protected]>
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -206,7 +206,7 @@ generate_C() {
 
 	#include "${HFILE}"
 
-	#define ${UDRIVER}_MIB_VERSION  "0.1"
+	#define ${UDRIVER}_MIB_VERSION  "0.01"
 
 	#define ${UDRIVER}_SYSOID       "${DEVICE_SYSOID}"
 

diff --git a/tools/nut-usbinfo.pl b/tools/nut-usbinfo.pl
@@ -361,7 +361,8 @@ sub find_usbdevs
 				$driver=$1;
 			}
 			else {
-				die "Unknown driver type: $nameFile";
+				warn "Unknown driver type: $nameFile";
+				next;
 			}
 			if ($vendor{$VendorID}{$ProductID}{"driver"}) {
 				if ($driver ne $vendor{$VendorID}{$ProductID}{"driver"}) {