Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert bugfix #299

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Revert bugfix #299

merged 1 commit into from
Jan 22, 2025

Conversation

agirbau
Copy link
Contributor

@agirbau agirbau commented Jan 22, 2025

Bugfix didn't take into account that min(True, 0) is 0, so there are no negative events

Bugfix didn't take into account that min(True, 0) is 0, so there are no negative events
@agirbau
Copy link
Contributor Author

agirbau commented Jan 22, 2025

I made this as a quick bugfix, but there is a bigger one, where there are events that share timestamp and pixel position (in the same pixel can happen 2 events at the same time, which shouldn't be possible).

Not sure how the original method should handle this @anindyaghosh

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.32%. Comparing base (a4e8a45) to head (30fb4da).
Report is 88 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #299      +/-   ##
===========================================
+ Coverage    77.07%   77.32%   +0.25%     
===========================================
  Files           54       56       +2     
  Lines         3067     3295     +228     
===========================================
+ Hits          2364     2548     +184     
- Misses         703      747      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biphasic
Copy link
Member

thank you for this!

@biphasic biphasic merged commit e410323 into neuromorphs:develop Jan 22, 2025
9 checks passed
@agirbau agirbau deleted the patch-1 branch January 22, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants