Disable computation of probabilities by default for MKDAChi2 #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why doc build is failing |
adelavega
changed the title
|
Can you update your branch from |
jdkent
reviewed
Jan 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
=======================================
Coverage 88.47% 88.48%
=======================================
Files 48 48
Lines 6333 6337 +4
=======================================
+ Hits 5603 5607 +4
Misses 730 730 ☔ View full report in Codecov by Sentry. |
tsalo
changed the title
jdkent
reviewed
Jan 4, 2024
There was a problem hiding this comment.
Can't view this diff, did you purposely change something in this example notebook?
There was a problem hiding this comment.
yes, there was a reference to the old naming style for chi2
There was a problem hiding this comment.
Restoring old notebook, as it needs updates that are out of the scope of this PR
jdkent
reviewed
Jan 4, 2024
Co-authored-by: James Kent <[email protected]>
jdkent
reviewed
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #855
priorargument inMKDAChi2optional, and only computes posterior probabilities based on prior if given