-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the correlation matrix computation in Stouffers and Reports #901
Conversation
Reviewer's Guide by SourceryThis pull request fixes the correlation matrix computation in the Stouffers method and Reports. The main changes involve simplifying the correlation matrix calculation by using numpy's corrcoef function directly on the input data, rather than iterating through data bags. This change affects both the nimare/reports/base.py and nimare/meta/ibma.py files. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JulioAPeraza - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment about the expected shape of the input data (self.inputs_['z_maps'] and self.results.estimator.inputs_[key_maps]) to improve clarity and maintainability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #901 +/- ##
==========================================
- Coverage 88.24% 88.23% -0.02%
==========================================
Files 48 48
Lines 6389 6382 -7
==========================================
- Hits 5638 5631 -7
Misses 751 751 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for removing the flaky test
Closes None.
Changes proposed in this pull request:
Summary by Sourcery
Fix the correlation matrix computation in the Stouffers and Reports modules by streamlining the calculation process and eliminating redundant code.
Bug Fixes: