-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step2: 블랙잭 #567
Open
ggam-nyang
wants to merge
22
commits into
next-step:ggam-nyang
Choose a base branch
from
ggam-nyang:step2
base: ggam-nyang
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Step2: 블랙잭 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
많이 늦어져버렸네요 ㅠㅠ
그런데 blackjackGame.start 메서드에서 Output, Input 로직을 호출하는 것이 어색한데, 분리가 잘 안되더라구요.. 😢
설계의 문제인지, 혹은 좋은 방법이 있는지 궁금합니다!
ps. 공식 리뷰 요청 기간이 지난것으로 알고 있습니다! 남은 미션도 완료하고자 하는데, PR을 요청드려도 되는건지 잘 모르겠습니다..!
리뷰 요청이 불가능한 것이라면 말씀해주세요!