[Spring Core]주병주 미션 제출합니다. #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
day024
reviewed
Jul 9, 2024
Comment on lines
+17
to
+25
| public class TestDataLoader implements CommandLineRunner { | ||
|
|
||
| private final MemberRepository memberRepository; | ||
|
|
||
| private final ThemeRepository themeRepository; | ||
|
|
||
| private final TimeRepository timeRepository; | ||
|
|
||
| private final ReservationRepository reservationRepository; |
There was a problem hiding this comment.
이런부분은 하나씩 공백이 있을 필요 없을 것 같아보입니다!
이외에도 불필요한 공백들이 보이는 것 같습니다:)
| import roomescape.member.Member; | ||
| import roomescape.member.MemberRepository; | ||
|
|
||
| @Profile("default") |
There was a problem hiding this comment.
Production용과 DataLoader와 Test용 TestDataLoader를 만드세요 라는 요구 사항이 있었는데, 저는 주어진 그대로 @Profile("Production") 라고 단순하게 접근했습니다.
그런데 병주님을 포함한 대부분의 분들이 @Profile("default") 라고 많이 작성해 주셨더라고요.
둘 다 큰 상관이 없는걸 까요? 이 부분 궁금해요!
added 18 commits
July 21, 2024 13:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
마지막 미션인데 그동안 수고 많으셨고 남은 해커톤도 화이팅해봐요!
이번주 미션을 제외한 곳은 저번 리뷰어분의 리뷰를 반영중입니다!