Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcEmojiPicker): arrow navigation #6466

Merged
merged 3 commits into from
Jan 30, 2025
Merged

fix(NcEmojiPicker): arrow navigation #6466

merged 3 commits into from
Jan 30, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 27, 2025 •
edited
Loading

Improving NcEmojiPicker: part 2 of 3

☑️ Resolves

This PR:

  • Adds arrow navigation using emoji-mart-vue-fast handlers with a custom fix
  • Makes sure TAB navigation doesn't go over 1000 emojis

Note: selecting the category tab only scrolls and doesn't select the first emoji in the category. Also not implemented by upstream.

🖼️ Screenshots

🏚️ Before 🏡 After
arrow-before arrow-after

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: emoji picker Related to the emoji picker component labels Jan 27, 2025
@ShGKme ShGKme added this to the 8.23.0 milestone Jan 27, 2025
@ShGKme ShGKme requested review from susnux, szaimen and Antreesy January 27, 2025 17:42
@ShGKme ShGKme self-assigned this Jan 27, 2025
@ShGKme ShGKme mentioned this pull request Jan 27, 2025
Draft
3 tasks
@ShGKme
fix(NcEmojiPicker): arrow navigation
cd4bdf6 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme force-pushed the fix/NcEmojiPicker--arrow-navigation branch from cbecc44 to fa3ceec Compare January 29, 2025 10:18
@ShGKme ShGKme marked this pull request as ready for review January 29, 2025 11:00
@ShGKme ShGKme requested review from Pytal and removed request for szaimen January 29, 2025 11:01
Antreesy
Antreesy approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean

src/components/NcEmojiPicker/NcEmojiPicker.vue Show resolved Hide resolved
@ShGKme ShGKme marked this pull request as draft January 29, 2025 13:43
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 29, 2025

Return focus is broken

@ShGKme ShGKme marked this pull request as ready for review January 29, 2025 20:37
Antreesy
Antreesy approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@ShGKme ShGKme force-pushed the fix/NcEmojiPicker--arrow-navigation branch from a2985b7 to 8ad1006 Compare January 30, 2025 08:50
@ShGKme ShGKme enabled auto-merge January 30, 2025 08:50
@ShGKme ShGKme merged commit b2be0c8 into master Jan 30, 2025
22 of 23 checks passed
@ShGKme ShGKme deleted the fix/NcEmojiPicker--arrow-navigation branch January 30, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@susnux susnux susnux approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working feature: emoji picker Related to the emoji picker component
Projects
None yet
Milestone
8.23.0
Development

Successfully merging this pull request may close these issues.

emoji picker focus missing
3 participants
@ShGKme @susnux @Antreesy