Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.19] Add New Capabilities For Compatible File Names #1635

Merged
merged 8 commits into from
Jan 17, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 16, 2025

Backport of PR #1494

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.01%. Comparing base (682baac) to head (5091cbf).
Report is 20 commits behind head on stable-2.19.

Files with missing lines Patch % Lines
...sources/status/GetCapabilitiesRemoteOperation.java 66.66% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             stable-2.19    #1635      +/-   ##
=================================================
+ Coverage          48.93%   49.01%   +0.07%     
- Complexity           996     1001       +5     
=================================================
  Files                206      206              
  Lines               7833     7849      +16     
  Branches            1019     1023       +4     
=================================================
+ Hits                3833     3847      +14     
+ Misses              3450     3449       -1     
- Partials             550      553       +3     
Files with missing lines Coverage Δ
...cloud/android/lib/resources/status/OCCapability.kt 94.20% <100.00%> (+0.35%) ⬆️
...sources/status/GetCapabilitiesRemoteOperation.java 51.32% <66.66%> (+0.56%) ⬆️

... and 1 file with indirect coverage changes

@alperozturk96 alperozturk96 requested a review from ZetaTom January 16, 2025 10:00
@tobiasKaminsky tobiasKaminsky merged commit b884b0a into stable-2.19 Jan 17, 2025
14 of 18 checks passed
@tobiasKaminsky tobiasKaminsky deleted the backport/1494/stable-2.19 branch January 17, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants