Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REDIS_HOST_USER variable to specify a redis user #2359

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

derhagen
Copy link
Contributor

@derhagen derhagen commented Jan 9, 2025

Our setup requires a 'user' => 'TheRealRedisUser' entry in config.php. This environment variable would make that easier.

@derhagen derhagen marked this pull request as ready for review January 10, 2025 14:08
@derhagen
Copy link
Contributor Author

@J0WI the errors from the previous run should be fixed now. feel free to start the test runner again.

btw is there any easy way to run your tests locally?

@J0WI
Copy link
Contributor

J0WI commented Jan 10, 2025

btw is there any easy way to run your tests locally?

sure: https://github.com/docker-library/official-images/tree/master/test

@derhagen
Copy link
Contributor Author

29.0.10-fpm-alpine looks like a flaky test to me. I don't quite get what went wrong in 29.0.10-fpm

@J0WI J0WI merged commit 5b932e3 into nextcloud:master Jan 11, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants