Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failing tests #2466

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: failing tests #2466

merged 1 commit into from
Dec 17, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews labels Dec 17, 2024
@hamza221 hamza221 self-assigned this Dec 17, 2024
@hamza221 hamza221 mentioned this pull request Dec 17, 2024
Merged
@hamza221 hamza221 marked this pull request as draft December 17, 2024 10:58
@hamza221
Copy link
Contributor Author

hamza221 commented Dec 17, 2024 •
edited
Loading

So if we use OCP\ServerVersion stable30 fails and if we use OC_Util::getVersion() master fails

@hamza221
fix: failing tests
afacbc4 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221 hamza221 marked this pull request as ready for review December 17, 2024 11:05
@hamza221 hamza221 requested a review from Chartman123 December 17, 2024 11:06
@hamza221 hamza221 merged commit 395af98 into main Dec 17, 2024
49 checks passed
@hamza221 hamza221 deleted the fix/unit-tests branch December 17, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chartman123 Chartman123 Chartman123 approved these changes

@jotoeri jotoeri Awaiting requested review from jotoeri

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamza221 @Chartman123