Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include circles to acl #3551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

include circles to acl #3551

wants to merge 1 commit into from

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jan 23, 2025 •
edited
Loading

This adds Teams to the ACL management:

  • search will now returns Teams and Teams' members so that Circles can be added to the list of ACL Manager in the admin settings of the app,
  • ACL rights about Teams and Teams' members can be set in the right panel when navigating a groupfolders' files,
  • ACL set regarding a Teams and Teams' members are applied to files and folders.

Missing front-end:

  • In the admin part, while the Teams' member are displayed, the Teams are missing in the dropdown list when adding ACL Manager. This is due to the fact that the data stored behind the array key 'circles' are not managed by the javascript.
  • In the admin part, when displaying a Team, it is shown as 'Group' instead of 'Team'
  • In the Files' right panel, while the Teams' member are displayed, the Teams are not in the dropdown list when adding ACL Permissions.

@sorbaugh sorbaugh requested a review from icewind1991 January 23, 2025 11:15
@ArtificialOwl ArtificialOwl force-pushed the feat/noid/acl-circles branch 3 times, most recently from 3b04873 to fafb1fa Compare January 24, 2025 10:43
@AndyScherzinger AndyScherzinger added enhancement 2. developing Items that are currently under development feature: acl Items related to the groupfolders ACL or "Advanced Permissions" labels Jan 25, 2025
@ArtificialOwl
include circles to acl
e654985 
Signed-off-by: Maxence Lange <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
2. developing Items that are currently under development enhancement feature: acl Items related to the groupfolders ACL or "Advanced Permissions"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArtificialOwl @icewind1991 @AndyScherzinger