chore(deps): Update psalm to v6 #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
provokateurin
added
3. to review
artonge
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Can't we have the exception in the code instead of in the baseline?
There was a problem hiding this comment.
I think the baseline is a better fit, in case this false positive gets fixed in a later psalm version. Otherwise we have an ignore in the code which would become useless. It's not like we intentionally want to ignore it because it is correct, we ignore it because psalm is broken.
artonge
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two new entries to the baseline are false positives IMO, because psalm has the wrong signature without the callable that can be seen in the docs: https://www.php.net/manual/en/function.array-udiff.php