Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(nginx-config): Listen port based on nextcloud.containerPort #278

Closed
wants to merge 1 commit into from
Closed

Fix(nginx-config): Listen port based on nextcloud.containerPort #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nextcloud/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: nextcloud
version: 3.1.1
version: 3.1.2
appVersion: 24.0.4
description: A file sharing server that puts the control and security of your own data back into your hands.
keywords:
Expand Down
2 changes: 1 addition & 1 deletion charts/nextcloud/templates/nginx-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ data:
}

server {
listen 80;
listen {{ .Values.nextcloud.containerPort | default 80 }};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the default value into the values file? That would make it easier to reuse for #316

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, there's 3 PRs for this that have been open for a couple of months (except mine that I opened today). @provokateurin, are you asking that that nextcloud.containerPort in values.yaml be set to 80?

@Nold360 if you don't have time, I can get this done via github suggestion commits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't figure out how to do a suggest on a new file, so I'm modifying #384 to include this change. Will close my PR if the other PRs are moved forward first.


# HSTS settings
# WARNING: Only add the preload option once you read about
Expand Down