Set default for nextcloud.containerPort in values.yaml and update YAML templates to use it everywhere #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebot
force-pushed
the
feature/use-containerport-as-targetport
branch
from
8979330 to
3db3077
Compare
|
relates to the following issues:
@provokateurin, I noticed you said in #278 (comment) that we should use a default value. Did you mean for helm/charts/nextcloud/values.yaml Line 88 in cd67e29 Happy to do the work to get all three PRs moved forward :) Also happy to add any docs you think might be handy |
jessebot
force-pushed
the
feature/use-containerport-as-targetport
branch
from
3db3077 to
d7c4941
Compare
|
Actually, I could forgo this PR entirely, as it looks like #316 already updates the service.yaml. Will close this if we can merge the other one. |
jessebot
changed the title
jessebot
force-pushed
the
feature/use-containerport-as-targetport
branch
2 times, most recently
from
142e942 to
7b8ba32
Compare
…e nextcloud.containerPort in service and deployment templates Signed-off-by: Jesse Hitch <[email protected]>
Signed-off-by: Jesse Hitch <[email protected]>
jessebot
force-pushed
the
feature/use-containerport-as-targetport
branch
from
7b8ba32 to
3d492ca
Compare
|
Have fixed up this PR because the other PRs that do something similar seem to have gone stale |
provokateurin
approved these changes
Apr 29, 2023
delete-merged-branch
bot
deleted the
feature/use-containerport-as-targetport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Reworked this PR to include other changes from two other PRs to move along these changes faster in bulk.
nextcloud.containerPortto be80in values.yaml.targetPortfor the nextcloud service to be thenextcloud.containerPort.httpports in the deployment template to usenextcloud.containerPortinstead (includes probes)Benefits
allows users to set a custom container port like
9000and have it be referenced in the service.Possible drawbacks
unsure, open to suggestion
Applicable issues
service.targetPortparameter or default tonextcloud.containerPortfor targetPort in service template #384Additional information
Checklist
Chart.yamlaccording to semver.