Limit the max nextUpdateTime delay to 24 hour #3074
Merged
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
approved these changes
Jan 28, 2025
|
Looks fine to me |
auto-merge was automatically disabled
January 30, 2025 09:58
Rebase failed
…ys and limit the time to the next update to a maximum of 24 hours Signed-off-by: Wolfgang <[email protected]>
Grotax
force-pushed
the
nextupdatetime
branch
from
ba7708c to
3eb5dcf
Compare
Grotax
added a commit
that referenced
this pull request
Jan 30, 2025
Changed - Set mobileLayout to `horizontal-split` and add nav buttons for articles in mobile view (#3046) - set the duration after which a feed is considered sleepy to 7 days when using `nextUpdateTime` (#3074) - limit the time to the next update to a maximum of 24 hours when using `nextUpdateTime` (#3074) Fixed - Show error on folders only if at least one feed has more than eight errors (#3073) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Jan 30, 2025
Changed - Set mobileLayout to `horizontal-split` and add nav buttons for articles in mobile view (#3046) - set the duration after which a feed is considered sleepy to 7 days when using `nextUpdateTime` (#3074) - limit the time to the next update to a maximum of 24 hours when using `nextUpdateTime` (#3074) Fixed - Show error on folders only if at least one feed has more than eight errors (#3073) Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #3013 the nextUpdateTime feed-io calculates is not always accurate and can push the next update too far in the future.
alexdebril/feed-io#434 will fix some problems, but for feeds with sporadic articles an accurate calculation is impossible.
Therefore, the maximum next update time should be limited to 24 hours, which is also the value used when a feed is recognized as sleeping.
This PR also sets the sleepy feed detection to the default of 7 days, which should work for most feeds. A small value like one or two days can cause feeds that have for example no posts on the weekend, not being downloaded until monday evening.
Checklist