fix: user:settings command when user is not available

If `ignore-missing-user` all sub commands work, except listing all settings for a user like `occ user:settings --ignore-missing-user user core`. Signed-off-by: Ferdinand Thiessen <[email protected]>
nextcloud · Jan 27, 2025 · eae1911 · eae1911
1 parent 6dc83b9
commit eae1911
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/core/Command/User/Setting.php b/core/Command/User/Setting.php
@@ -213,13 +213,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 				return 1;
 			}
 		} else {
+			$ignoreMissingUser = $input->getOption('ignore-missing-user');
 			$settings = $this->getUserSettings($uid, $app);
 			$this->writeArrayInOutputFormat($input, $output, $settings);
 			return 0;
 		}
 	}
 
-	protected function getUserSettings($uid, $app) {
+	protected function getUserSettings(string $uid, string $app) {
 		$settings = $this->config->getAllUserValues($uid);
 		if ($app !== '') {
 			if (isset($settings[$app])) {
@@ -230,7 +231,10 @@ protected function getUserSettings($uid, $app) {
 		}
 
 		$user = $this->userManager->get($uid);
-		$settings['settings']['display_name'] = $user->getDisplayName();
+		if ($user !== null) {
+			// Only add the display name if the user exists
+			$settings['settings']['display_name'] = $user->getDisplayName();
+		}
 
 		return $settings;
 	}