fix: add eol in dav command and use success const as return code

[GreyXor]

• Resolves: Each CLI commands should return a end-of-line after execution

Summary

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[GreyXor]

@come-nc Hello, would you mind review my PR ? Thanks !

[come-nc]

self::FAILURE should be used instead of return 1 for consistency.

[GreyXor]

Thanks and done 👍
@come-nc Can you tell me if I should mention someone else for a review and a merge ?

[come-nc]

@GreyXor Can you have a look at https://github.com/nextcloud/server/pull/48800/checks?check_run_id=35620554716 and see if you can fix DCO? The idea is to use git commit --signoff (or -s).
In your situation you can use git rebase commant with --signoff option to edit existing commit before force push.
You can also rebase on master to avoid the merge commits.

[GreyXor]

@GreyXor Can you have a look at https://github.com/nextcloud/server/pull/48800/checks?check_run_id=35620554716 and see if you can fix DCO? The idea is to use git commit --signoff (or -s). In your situation you can use git rebase commant with --signoff option to edit existing commit before force push. You can also rebase on master to avoid the merge commits.

Thanks, I signed it

[come-nc]

Failed tests are unrelated.

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[come-nc]

@GreyXor Thank you for your contribution.

If you are interested in Nextcloud development, do you want me to create a guest account for you on our Talk instance where we host a community dev chat?

[GreyXor]

@GreyXor Thank you for your contribution.

If you are interested in Nextcloud development, do you want me to create a guest account for you on our Talk instance where we host a community dev chat?

I’d truly love to engage further, but unfortunately, I don’t have the time or bandwidth at the moment to actively participate.

I’ll continue to follow the project and contribute whenever I can though. Thanks again!

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)