chore: Resolve ESLint warnings #49348
Merged
+34
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
requested review from
a team,
Pytal and
szaimen
and removed request for
a team
skjnldsv
approved these changes
Nov 19, 2024
This comment was marked as resolved.
This comment was marked as resolved.
susnux
force-pushed
the
fix/eslint-warnings
branch
from
9af10ec to
de84cfd
Compare
susnux
requested review from
nfebe and
artonge
and removed request for
Pytal
Merged
artonge
approved these changes
Jan 16, 2025
susnux
force-pushed
the
fix/eslint-warnings
branch
from
de84cfd to
a7bc3bf
Compare
- Add default value to non-required Vue props - Reformat function to async function if needed - Add some documentation - Allow `any` in places where it makes sense (tests) - Order vue component sections as required Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/eslint-warnings
branch
from
a7bc3bf to
1bed442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some more cleanup after we re-enabled proper linting on the project:
anyin places where it makes sense (tests)Checklist