Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show full template name #50172

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix: Show full template name #50172

merged 2 commits into from
Jan 15, 2025

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 14, 2025

Summary

After discussion with @marcoambrosini we came to the conclusion that showing the full name for templates seems more reasonable. There may be different templates with similar names like shown in the screenshots where it is otherwise hard to tell which to pick:

Before After
Screenshot 2025-01-14 at 12 48 31 Screenshot 2025-01-14 at 12 48 40

Checklist

@skjnldsv skjnldsv mentioned this pull request Jan 14, 2025
@juliusknorr juliusknorr force-pushed the fix/template-name-overflow branch from a753ed7 to 10d4998 Compare January 14, 2025 18:38
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😃

@skjnldsv
Copy link
Member

/compile rebase

juliusknorr and others added 2 commits January 15, 2025 08:34
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the fix/template-name-overflow branch from 10d4998 to 8111068 Compare January 15, 2025 08:36
@skjnldsv skjnldsv enabled auto-merge January 15, 2025 08:46
@skjnldsv skjnldsv merged commit eef5663 into master Jan 15, 2025
120 checks passed
@skjnldsv skjnldsv deleted the fix/template-name-overflow branch January 15, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants