Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(dashboard): Add regression test for loading unneeded data #50179

Merged
merged 1 commit into from
Jan 16, 2025
Merged

test(dashboard): Add regression test for loading unneeded data #50179

merged 1 commit into from
Jan 16, 2025
+41 −0

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 14, 2025 •
edited
Loading

Summary

  • Fails before the PR of @st3iny
  • Succeeds afterwards ✔️

Checklist

@susnux susnux added 3. to review Waiting for reviews tests Related to tests labels Jan 14, 2025
@susnux susnux added this to the Nextcloud 31 milestone Jan 14, 2025
st3iny
st3iny approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

Does it indeed fail when reverting 0bb7be2.

nickvergessen
nickvergessen approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you say this works :)

@susnux
Copy link
Contributor Author

susnux commented Jan 16, 2025

/backport! to stable30

@backportbot backportbot bot mentioned this pull request Jan 16, 2025
Closed
@susnux
test(dashboard): Add regression test for loading unneeded data
2556da5 
Prevent a regression of #48403

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux merged commit f40dd53 into master Jan 16, 2025
120 checks passed
@susnux susnux deleted the test/widget-perf branch January 16, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@st3iny st3iny st3iny approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews tests Related to tests
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @nickvergessen @st3iny