docs: Use proper return type for custom template listing #50196
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came up with nextcloud/richdocuments#4386 in psalm
We have the wrong return type annotated, the returned list is using
Template
objects, which is also what all existing implementations do and what the usage expects:server/lib/private/Files/Template/TemplateManager.php
Lines 188 to 195 in efa615b
https://github.com/nextcloud/richdocuments/blob/ba9c364e952fed85dd7431f711b57246b9e268f3/lib/Template/CollaboraTemplateProvider.php#L47
https://github.com/ONLYOFFICE/onlyoffice-nextcloud/blob/d20b985948957de6785a5e126aa9d63dd668b453/lib/TemplateProvider.php#L69