fix(contactsmenu): adjust padding to new design #50532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
bug
design
|
/backport to stable31 |
|
/backport to stable30 |
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
fix/contactsmenu/padding
branch
from
958fb8e to
d40031d
Compare
|
Why does this even need custom styling? Could it just use the default ncaction styles? |
I wish. The problem is that contact menu actions may inject custom image URLs as their icons which cannot be used with our That is why we need custom styles here. |
ChristophWurst
approved these changes
Jan 29, 2025
susnux
reviewed
Jan 29, 2025
| @@ -114,13 +113,9 @@ export default { | |||
| &__icon { | |||
| width: 20px; | |||
| height: 20px; | |||
| padding: 12px; | |||
| padding: 7px; | |||
There was a problem hiding this comment.
Suggested change
| padding: 7px; | |
| padding: calc((var(--default-clickable-area) - 20px) / 2); |
There was a problem hiding this comment.
Independent from other styles, only magic number is the icon size we set above.
susnux
reviewed
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Padding and white space inside the contacts menu has not yet been adjusted to the new clickable area of 34 px.
Checklist