add composer, gh workflows and vue8 support #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anupam Kumar <[email protected]>
Signed-off-by: Anupam Kumar <[email protected]>
julien-nc
requested changes
Mar 5, 2024
| @@ -1 +1 @@ | |||
| /appinfo/info.xml @julien-nc | |||
| /appinfo/info.xml @julien-nc @kyteinsky | |||
There was a problem hiding this comment.
Suggested change
| /appinfo/info.xml @julien-nc @kyteinsky | |
| /appinfo/info.xml @kyteinsky @julien-nc |
There was a problem hiding this comment.
If you want to match two or more code owners with the same pattern, all the code owners must be on the same line. If the code owners are not on the same line, the pattern matches only the last mentioned code owner.
All have the same priority. Why is it limited to only info.xml though?
There was a problem hiding this comment.
This is Nextcloud specific syntax, for the security bulletin done internally by the security team
julien-nc
approved these changes
Mar 5, 2024
Signed-off-by: Anupam Kumar <[email protected]>
|
screenshots below. There is a slight glitch with the selector dropdown but not an issue from this end and did auto-correct itself.
|
marcelklehr
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: vue8