Improve error messages

Signed-off-by: Ben Sherman <[email protected]>
nextflow-io · Jan 22, 2025 · 84e9618 · 84e9618
1 parent 83ea561
commit 84e9618
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/modules/compiler/src/main/java/config/parser/ConfigAstBuilder.java b/modules/compiler/src/main/java/config/parser/ConfigAstBuilder.java
@@ -518,7 +518,7 @@ private Statement assignment(AssignmentStatementContext ctx) {
         if ( isAssignmentLhsValid(left) )
             return stmt(ast( binX(left, token(ctx.op), expression(ctx.right)), ctx ));
 
-        throw createParsingFailedException("Invalid assignment target -- should be a variable, index, or property expression", ctx);
+        throw createParsingFailedException("Invalid assignment target -- must be a variable, index, or property expression", ctx);
     }
 
     private boolean isAssignmentLhsValid(Expression left) {

diff --git a/modules/compiler/src/main/java/script/parser/ScriptAstBuilder.java b/modules/compiler/src/main/java/script/parser/ScriptAstBuilder.java
@@ -321,7 +321,7 @@ private FeatureFlagNode featureFlagDeclaration(FeatureFlagDeclarationContext ctx
         var value = expression(ctx.expression());
         var result = ast( new FeatureFlagNode(name, value), ctx );
         if( !(value instanceof ConstantExpression) )
-            collectSyntaxError(new SyntaxException("Feature flag value should be a literal value (number, string, true/false)", result));
+            collectSyntaxError(new SyntaxException("Feature flag value must be a literal value (number, string, true/false)", result));
         return result;
     }
 
@@ -570,7 +570,7 @@ private Statement workflowEmits(WorkflowEmitsContext ctx) {
     private Statement workflowEmit(StatementContext ctx) {
         var result = statement(ctx);
         if( !(result instanceof ExpressionStatement) ) {
-            collectSyntaxError(new SyntaxException("Invalid workflow emit -- should be a name, assignment, or expression", result));
+            collectSyntaxError(new SyntaxException("Invalid workflow emit -- must be a name, assignment, or expression", result));
             return null;
         }
         saveTrailingComment(result, ctx);
@@ -845,7 +845,7 @@ private Statement assignment(AssignmentStatementContext ctx) {
         if ( isAssignmentLhsValid(left) )
             return stmt(ast( new AssignmentExpression(left, token(ctx.op), expression(ctx.right)), ctx ));
 
-        throw createParsingFailedException("Invalid assignment target -- should be a variable, index, or property expression", ctx);
+        throw createParsingFailedException("Invalid assignment target -- must be a variable, index, or property expression", ctx);
     }
 
     private boolean isAssignmentLhsValid(Expression left) {