Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle plugin proof-of-concept #21

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

tom-seqera
Copy link
Contributor

No description provided.

Signed-off-by: Tom Sellman <[email protected]>
@bentsherman
Copy link
Member

Just tested this with nf-prov and it works wonderfully. So much simpler 😄

Some notes:

  • I would make the assemble rule first in the Makefile so that you can just run make to build the plugin

  • I happen to have nf-prov cloned as a different name (nextflow-io_nf-prov), and make install used that name when installing the plugin. Setting rootProject.name to nf-prov in settings.gradle fixed this, so I would do this in nf-hello as well

  • I initially moved my source files to src/main/nextflow/... instead of src/main/groovy/nextflow/.... The plugin built and installed successfully, but then Nextflow failed at runtime with a ClassNotFound exception.

    It sounds like the plugin build didn't pick up any classes, so I'm surprised it still succeeded. Since we specify the className in the build.gradle, maybe it can confirm that at least this class was picked up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants