log detail errors from remote #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Aguilera <[email protected]>
Signed-off-by: Jorge Aguilera <[email protected]>
abhi18av
approved these changes
Jul 4, 2024
| try { | ||
| jobsApi.deleteJob(jobId, config.jobOpts().region, config.jobOpts().namespace, null, null, purge, true) | ||
| }catch(Exception e){ | ||
| log.error("[NOMAD] Failed to delete job ${jobId} -- Cause: ${e.message ?: e}", e) |
There was a problem hiding this comment.
@jagedn , do you think that within an exception block, we should use only log.debug or this should be decided as per the context?
I think error makes sense for session terminating steps and not for the retries - what do you think?
There was a problem hiding this comment.
good question
yes, you're right, probably we can use only debug level in retries and if the user want to have more details can change the level
There was a problem hiding this comment.
Thanks Jorge, I've refactored accordingly 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some situations we need more details about the error returned by the server so log them