Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task script to legacy format #28

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

stevekm
Copy link
Contributor

@stevekm stevekm commented Mar 19, 2024

fixes #24

@bentsherman bentsherman changed the title add task script to LegacyRenderer.groovy Add task script to legacy format Mar 22, 2024
@bentsherman
Copy link
Member

bentsherman commented Mar 22, 2024

I was thinking to wait to do this as part of #16 , but it's a simple change so might as well do it now.

Did you test the change and are you happy with the output?

@stevekm
Copy link
Contributor Author

stevekm commented Mar 22, 2024

It looks OK so far

My only real gripe is that newlines in the Nextflow process script section show up as \n in the JSON, however I looked into it and it seems that JSON does not actually allow for real newlines in string fields, so I think its unavoidable.

if there's any other changes needed I expect we can just do a followup for that later.

thanks

@bentsherman
Copy link
Member

indeed, that's what you have to do with JSON, but conversely, if you view the JSON through a tool or GUI rather than directly, the tool will put the newlines back in for you

@bentsherman bentsherman merged commit f07ff65 into nextflow-io:master Mar 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add the "script" section to the manifest JSON file
2 participants