Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes display of configFiles entries in parameter summary text #76

Merged

Conversation

scwatts
Copy link
Contributor

@scwatts scwatts commented Nov 1, 2024


Simplified operations

def a = [1, 2, 3]

def String b = a
def c = b.join(', ')

def d = a.join(', ')

println "a ${a}"
println "b ${b}"
println "c ${c}"
println "d ${d}"

Output

a [1, 2, 3]
b [1, 2, 3]
c
d 1, 2, 3

@nvnieuwk
Copy link
Collaborator

nvnieuwk commented Nov 1, 2024

It seems like this broke some things in the plugin, can you take a look at it? (You can run make test to run the tests locally)

@scwatts
Copy link
Contributor Author

scwatts commented Nov 2, 2024

Thanks for pointing that out! I've updated the fix and tests are now passing, and I confirmed the change causes config files to be shown in the parameter summary as expected after executing make install and then running example given in the corresponding issue.


------------------------------------------------------
                                        ,--./,-.
        ___     __   __   __   ___     /,-._.--~'
  |\ | |__  __ /  ` /  \ |__) |__         }  {
  | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                        `._,._,'
  nf-core/configfilesdebug 1.0.0dev
------------------------------------------------------
Input/output options
  input      : assets/samplesheet.csv
  outdir     : output/

Core Nextflow options
  runName    : sharp_brattain
  launchDir  : /Users/stephen/temp/delete/configfiles-debug
  workDir    : /Users/stephen/temp/delete/configfiles-debug/work
  projectDir : /Users/stephen/temp/delete/configfiles-debug
  userName   : stephen
  profile    : standard
  configFiles: /Users/stephen/temp/delete/configfiles-debug/nextflow.config, /Users/stephen/temp/delete/configfiles-debug/first.config, /Users/stephen/temp/delete/configfiles-debug/second.config

!! Only displaying parameters that differ from the pipeline defaults !!
------------------------------------------------------

@nvnieuwk
Copy link
Collaborator

nvnieuwk commented Nov 4, 2024

Awesome, can you also update the changelog? Next version should be v2.3.0

@scwatts
Copy link
Contributor Author

scwatts commented Nov 7, 2024

Done, and appreciate all the patience!

Copy link
Collaborator

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome LGTM!

@nvnieuwk nvnieuwk merged commit 51069b9 into nextflow-io:master Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants