Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-co2footprint version 1.0.0-beta.1 added #110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Bastian-Eisenmann
Copy link

@Bastian-Eisenmann Bastian-Eisenmann commented Jan 9, 2025

Version 1.0.0-beta.1

Features:

  • Plot co2e and energy in one plot with two axis.
  • Report nf-co2footprint version in co2footprint_report_*.html and co2footprint_summary_*.txt reports.
  • Show Plugin parameters in html and text reports.
  • Show CO2 equivalences using scientific annotations in the html reports.
  • Show CO2 equivalences in text reports.
  • Updated documentation.

@bentsherman
Copy link
Member

It might be better to call it 1.0.0-beta1. I think the extra dot will throw off the semantic versioning

@pditommaso
Copy link
Member

I fear the opposite, currently we are using the .digit syntax

https://github.com/nextflow-io/plugins/blob/main/plugins.json#L1908-L1923

If I'm not wrong pf4j is not able to handle it otherwise

@bentsherman
Copy link
Member

I guess we are using both:

"version": "1.6.3-patch1",

So both will work for now. But I suspect the four-part syntax will break if we move towards semantic versioning nextflow-io/nextflow#5435

@pditommaso
Copy link
Member

You are right, ignore my previous comment. Semver syntax is the correct one.

@Bastian-Eisenmann
Copy link
Author

Hi, so you prefer 1.0.0-beta1 right?

@bentsherman
Copy link
Member

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants